Better pose filtering by confidences #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThagonDuarte
force-pushed
the
filter_poses_more_strictly
branch
2 times, most recently
from
a526fd5
to
9c3f3d0
Compare
knoellle
requested changes
Jul 5, 2024
ThagonDuarte
force-pushed
the
filter_poses_more_strictly
branch
3 times, most recently
from
71b62dc
to
8fc671f
Compare
knoellle
requested changes
Jul 7, 2024
ThagonDuarte
force-pushed
the
filter_poses_more_strictly
branch
2 times, most recently
from
d1c5bb0
to
6857f1d
Compare
Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com>
…anel Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com>
ThagonDuarte
force-pushed
the
filter_poses_more_strictly
branch
from
6857f1d
to
13ac73d
Compare
3 tasks
oleflb
added a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
* Renaming thresholds * Filter poses by keypoint confidences * Renaming * Draw bounding box of pose * Seperate confidence filters for important and other keypoints * Add pose filter, seperate filtered and unfiltered poses * Rename object_detection parameters object to pose_detection * Fix pose subscription path * Add switch between unfiltered and filtered pose painting Format * Add pose detection dead zone indicator * Increase `pose_detection.bounding_box_confidence_threshold` * Bump twix * Split uses correctly * Split uses here correctly as well * Fix rebase error * Address review comments die Erste * Address review comments die Zweite Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com> * Draw accepted, rejected and referee pose kind positions in twix map panel Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> * Revert visual referee recording * Fix rebase error * Fix shoulder angle calculation --------- Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com>
oleflb
added a commit
that referenced
this pull request
Sep 30, 2024
* Renaming thresholds * Filter poses by keypoint confidences * Renaming * Draw bounding box of pose * Seperate confidence filters for important and other keypoints * Add pose filter, seperate filtered and unfiltered poses * Rename object_detection parameters object to pose_detection * Fix pose subscription path * Add switch between unfiltered and filtered pose painting Format * Add pose detection dead zone indicator * Increase `pose_detection.bounding_box_confidence_threshold` * Bump twix * Split uses correctly * Split uses here correctly as well * Fix rebase error * Address review comments die Erste * Address review comments die Zweite Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com> * Draw accepted, rejected and referee pose kind positions in twix map panel Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> * Revert visual referee recording * Fix rebase error * Fix shoulder angle calculation --------- Co-authored-by: ole.flb <45100017+oleflb@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
A lot of the false positives that cause Motion in Standby, happen when people (or naos) are only partially present in the image. This PR uses the confidence values the yolo network provides for every keypoint, in addition to the bounding box confidences, to filter out those poses. Three confidence thresholds now provide granular control over the filtering.
Implements #985
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
pose_detection