disallow instant kicks in penalty shootout and penalty kick #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivituhh
added
test:Field Needed
oleflb
requested changes
Jul 14, 2024
| @@ -154,6 +154,20 @@ fn collect_kick_targets( | |||
| }) | |||
| ); | |||
|
|
|||
| let is_penalty_shoot = matches!( | |||
There was a problem hiding this comment.
Prefer matching both patterns simultaneously using | and only one matches!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Tests for penalty shootout looked better without instant kicks. In my opinion a little jockeling is fine in this phase.
More small changes to addresses #546.
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Use GameController in Penalty Shootout with a HULKs striker and compare main against this.