More dense candidates #1399
Open
More dense candidates #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3ndrk
force-pushed
the
more-dense-candidates
branch
2 times, most recently
from
9fc0887
to
0fa8dca
Compare
h3ndrk
force-pushed
the
more-dense-candidates
branch
from
219bf8e
to
aed4b61
Compare
|
I guess, this is still in progress @h3ndrk? |
|
No, this is ready for review, it is on the board, description is up-to-date. |
schmidma
reviewed
Aug 1, 2024
| } | ||
| ); | ||
| } | ||
| // TODO: Fix and reenable tests |
There was a problem hiding this comment.
But this PR still contains TODOs ?!
There was a problem hiding this comment.
Yes, as mentioned in the PR description, this can be tackled in a next iteration. These tests don't have much impact.
|
Someone should fix these tests :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
ToDo / Known Issues
None
Ideas for Next Iterations (Not This PR)
How to Test
Use the ball detection image overlay or/and ball candidates panel in Twix to see the changes. We should detect the ball better or similar as before.