Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
Localization was bronek because line detection was outputting lines in 422 coordinates.
Fixes #53
Ideas for Next Iterations (Not This PR)
After
ripgrep
ping through our whole repository for/ 2
and* 2
, I didn't find any more locations where 422 and 444 coordinates may have been mixed up, except for flora.How to Test
Localization should finally work again. 🎉
For testing the map layer, the projected lines should match the projected image segments as well as the field lines drawn using the field dimensions +- robot shaking & slight delocalization.