Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line detection 422 begone #61

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

knoellle
Copy link
Contributor

@knoellle knoellle commented Jan 25, 2023

Introduced Changes

Localization was bronek because line detection was outputting lines in 422 coordinates.

  • Removes 422 -> 444 conversions from line detection in both nao code and twix
  • Adds map layer that shows detected lines
    • Map layers sorted by size / importance

Fixes #53

Ideas for Next Iterations (Not This PR)

After ripgrepping through our whole repository for / 2 and * 2, I didn't find any more locations where 422 and 444 coordinates may have been mixed up, except for flora.

  • Port whatever panels are still flora exclusive and delete flora

How to Test

Localization should finally work again. 🎉

For testing the map layer, the projected lines should match the projected image segments as well as the field lines drawn using the field dimensions +- robot shaking & slight delocalization.

@knoellle knoellle added cat:Localization cat:Vision is:Bug This is a bug and should be prioritised. labels Jan 25, 2023
@knoellle knoellle enabled auto-merge (rebase) January 25, 2023 20:50
@schmidma schmidma self-assigned this Jan 26, 2023
Copy link
Member

@schmidma schmidma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, this looks fine to me.
I'll test it this evening.

@knoellle knoellle merged commit 97494d5 into HULKs:main Jan 27, 2023
@knoellle knoellle deleted the line-detection-422-begone branch January 28, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:Localization cat:Vision is:Bug This is a bug and should be prioritised.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Loca komplett im Arsch
2 participants