Make hulks website international #95
Conversation
There was a problem hiding this comment.
Nice work with the meet page! LGTM, minor remarks - one has to be answered by @PatrickGoettsch I guess.
I also noticed that we still have a german impress and I guess that we have to keep that? Do we want to change the link to the impress on the bottom of each page to "Impress/Impressum" or should be just leave it as it is?
| @@ -11,7 +11,7 @@ | |||
| <h1>HULKs</h1> | |||
| <p> | |||
| <b>RoboCup SPL Team<br /> | |||
| TU Hamburg, Germany</b> | |||
| TUHH, Germany</b> | |||
There was a problem hiding this comment.
I would keep TU Hamburg to keep it consistent with our current logo. Is there a reason to change this?
There was a problem hiding this comment.
The reason why I made this change is because TU (Technische Universität) is a German expression and does not exist in the English name of the university (Hamburg University of Technology). Therefore, one could either use the English name (Hamburg University of Technology) which is fairly long, or use the official abbreviation of our university (TUHH).
There was a problem hiding this comment.
In my personal feeling, TU Hamburg or TUHH feels more "normal" than Hamburg University of Technology, in fact if you directly translate, TU Hamburg is the outcome considering pattern used by TuM, etc (Google and Deepl now show official one for TUHH). IDK why they have the official translation as it is.
Note to myself: Read the PR description first 🦄 |
|
This also fixes #94 |
|
I left the link to the imprint in German since the imprint is still written in German. Once we have an English version of the imprint as well, we can change it to "Imprint/Impressum". |
|
I fixed the RoHOW link and the mail about thesis (in English or German) stuff. |
Solves hulks/nao#2145
Description
The complete hulks.de website has been translated to English. The only exception is the Impressum (with disclaimer) which still remains German for legal reasons.
There are some small content changes on the Meet HULKs page as well: The team photo has been replaced by our "We want you" recruiting picture and the recruiting page (recruiting.hulks.de) is linked now.