Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some issues of the PSI meeting #65

Closed
wants to merge 2 commits into from

Conversation

julianu
Copy link
Contributor

@julianu julianu commented Apr 18, 2019

- added PSI MS relations (HUPO-PSI#54)
- removed length information from value (HUPO-PSI#57)
@bittremieux
Copy link
Collaborator

As for the question in point 3, I think the size of tables and matrices should similarly be defined implicitly.

Do we need to have the unit ontology obo in this repository as well? We're not maintaining it, so it'll get out of date. Why not rather keep it at its original location and refer to it there?

@dtabb73
Copy link
Collaborator

dtabb73 commented Apr 30, 2019

Hi, folks. As I understood it, we should have a CV 0.1.1 for me to use in updating my QuaMeter IDFree example. Is there a reason this pull request hasn't been integrated?

@mwalzer
Copy link
Collaborator

mwalzer commented Apr 30, 2019

@dtabb73: Wout raised at least one point we should consider (regarding the uo.obo) and the other one I try to make sense of. @bittremieux which question in point 3 are you referring to? In fact, which point 3 - #63?

@mwalzer
Copy link
Collaborator

mwalzer commented Apr 30, 2019

@julianu : I agree with @bittremieux on the uo.obo matter. There would be two solutions for a link if you need it in the MzQC structure (and I also see that it would be useful to have that one available, too, when you check out a local copy of MzQC):

@mwalzer
Copy link
Collaborator

mwalzer commented Apr 30, 2019

@julianu was this the origin of the uo.obo?

@bittremieux
Copy link
Collaborator

bittremieux commented Apr 30, 2019

@mwalzer The question in parentheses in point 3 in the readme.

mwalzer added a commit that referenced this pull request May 28, 2019
Moving branches of #65 for easier coop
@mwalzer
Copy link
Collaborator

mwalzer commented May 28, 2019

PR moved here: #67
Further discussion there. You can also commit to that branch.

@mwalzer mwalzer closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants