Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create app and initialize req #1

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Create app and initialize req #1

merged 2 commits into from
Jan 3, 2023

Conversation

Haadiiii
Copy link
Owner

@Haadiiii Haadiiii commented Jan 3, 2023

Hello react front-end ⏬

  • Create a new React app called 'hello-react-front-end'
  • Initialize project with Git.
  • Create the App component with react-router.
  • Create the Greeting component that will display a greeting. Set it up as a route in your App component.
  • Create a store, an action and a reducer that will connect to you API endpont to get the random greeting.
  • Display the random greeting in your Greeting component.

https://github.com/Haadiiii/hello-rails-back-end

@Haadiiii Haadiiii merged commit 9d62515 into dev Jan 3, 2023
Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @Haadiiii,

Good job !!!

To Highlight! 👏 🟢

✔️ Good commit messages
✔️ Descriptive Readme file

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines +6 to +12
const App = () => {
return (
<Provider store={store}>
<Greeting />
</Provider>
)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [OPTIONAL] Please according to the project requirements, "Create the App component with react-router." , please your App component should be created with routes(from react-router), and should have route that leads to the Greeting component. Please kindly fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants