Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Extension Update #88

Merged
merged 16 commits into from
May 1, 2014
Merged

Chrome Extension Update #88

merged 16 commits into from
May 1, 2014

Conversation

goldbattle
Copy link
Contributor

Hello, I have just started using the main website and this chrome extension is important to me to be working. I use it as I use the stayfocus extension. I have read through the issues and saw that nobody has the time to give this any love. So I started updating it and working on it. Currently it is in a better state then I downloaded it in. Please see the list below:

Issues that shouldn't be an issue:

A screenshot of the updated styles. Using full bootstrap 3 instead of colored blocks etc.
capture2capture3

Let me know what you think. I need to continue and update the todo integration as that was broken and I have not had time yet to work on it. I am going to try to allow for complete interaction inside the extension so a user does not have to go to the HabitRPG website or have the HabitRPG open in a pinned tab. Let me know what you think. Great project, and I like how this is all open source.

My todos I want to get done:

  • Add the ability to see your tasks
  • Fix middle click tab detection
  • Add ability to edit your tasks
  • Standardize the formatting throughout the files
  • Work on binds to websites
  • Maybe show the user's picture
  • Update options page with new style
  • Add more functions for domain specifications
  • Get it closer to Stay Focus's style of adding/removing websites

- use correct notification cancel method
- Remove a random script tag
- take into account that there is a scrollbar that can cover the content
- point to official repo
- reorder
- Going to make a different file
- Move old css and popup
- Going to add things slowly back in
- Going to update formating
- Working progress bar
- Formatted nicely
- Edited the colors a bit
- Added player bars
- It is now back to where it was before I removed everything
- Seems that the app does not have focus when
- opening a new tab
- typing url, and then pressing enter
- Fixed the error explained above
- A bit of formatting
- Use the api v2 url
- You can see your task
- If you do not have uncompleted ones the blocks do not display
- Make the popup a bit wider for the scroll bar
- Added some <hr> tags to space things nicely
- Sorry for the small commits, just trying to tweak for the pull
request.
@lefnire
Copy link
Contributor

lefnire commented Apr 24, 2014

mother of god.... this will make people so happy, I'll check into this soon as I can

@goldbattle
Copy link
Contributor Author

There is still a bug when you middle click and open a new tab it does not check the url/what type of website it is. I am heading to bed, probably will not have time till the weekend to work on this. Hope it is up to the standard you have.

@lefnire
Copy link
Contributor

lefnire commented May 1, 2014

@goldbattle I'm gonna merge this and play with it in coming days. I'll let you know if I hit any hitches, but this project is so unkempt it can't afford my bottlenecking in code review. If all's well, I'll deploy and set you as a project collaborator so you can direct-commit.

What's your UUID for contrib reward, @deilann can you do the honors?

lefnire added a commit that referenced this pull request May 1, 2014
@lefnire lefnire merged commit a219628 into HabitRPG:master May 1, 2014
@deilann
Copy link

deilann commented May 1, 2014

o7

On Thu, May 1, 2014 at 12:09 PM, Tyler Renelle notifications@github.comwrote:

@goldbattle https://github.com/goldbattle I'm gonna merge this and play
with it in coming days. I'll let you know if I hit any hitches, but this
project is so unkempt it can't afford my bottlenecking in code review. If
all's well, I'll deploy and set you as a project collaborator so you can
direct-commit.

What's your UUID for contrib reward, @deilann https://github.com/deilanncan you do the honors?


Reply to this email directly or view it on GitHubhttps://github.com//pull/88#issuecomment-41945053
.

@lefnire
Copy link
Contributor

lefnire commented May 1, 2014

Anyone else want to help test this:

  • git clone https://github.com/HabitRPG/habitrpg-chrome.git
  • cd habitrpg-chrome && npm install && grunt chrome
  • Load Unpacked Extension

@goldbattle
Copy link
Contributor Author

If I have time this weekend I will add some more. Finals are coming up so school is a priority right now. I will see what I can get done. I really want to get it so you can interact from the extension. Thank you!

53e6fb5e-5ed0-416c-b68f-9efbdf6766c5

@deilann
Copy link

deilann commented May 1, 2014

lvl++ !!

On Thu, May 1, 2014 at 1:52 PM, goldbattle notifications@github.com wrote:

If I have time this weekend I will add some more. Finals are coming up so
school is a priority right now. I will see what I can get done. I really
want to get it so you can interact from the extension. Thank you!

53e6fb5e-5ed0-416c-b68f-9efbdf6766c5


Reply to this email directly or view it on GitHubhttps://github.com//pull/88#issuecomment-41955426
.

@robeden
Copy link

robeden commented May 2, 2014

Basic usage seems to be working for me so far.

@lefnire
Copy link
Contributor

lefnire commented May 2, 2014

Likewise, will deploy hopefully today
On May 2, 2014 10:25 AM, "Rob Eden" notifications@github.com wrote:

Basic usage seems to be working for me so far.


Reply to this email directly or view it on GitHubhttps://github.com//pull/88#issuecomment-42050158
.

@lefnire
Copy link
Contributor

lefnire commented May 4, 2014

@goldbattle thanks so much for this PR. I've been using it for the last few days and all's well - we've pushed live as v2.1. I've made you a repo admin, feel free to direct-commit hotfixes and basic things. For bigger changes, or things you'd like a code review on, send PRs.

@lefnire
Copy link
Contributor

lefnire commented May 5, 2014

@goldbattle I'm gonna contrib.lvl++ you again, this was a pretty big contrib

@agnesnutter
Copy link
Contributor

My goodness, goldbattle, thank you so much for this much-needed update! This is amazing! :D

Has the update been pushed to the Chrome Web Store already?

@lefnire
Copy link
Contributor

lefnire commented May 5, 2014

Yeah, thanks goldbrother! (esp. funny to me since a co-founder ref'd you as goldbetter)

Yes, update's live at 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants