-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome Extension Update #88
Conversation
- use correct notification cancel method - Remove a random script tag
- take into account that there is a scrollbar that can cover the content
- point to official repo - reorder
- Going to make a different file
- Move old css and popup - Going to add things slowly back in - Going to update formating
- Working progress bar - Formatted nicely
- Edited the colors a bit - Added player bars - It is now back to where it was before I removed everything
- Seems that the app does not have focus when - opening a new tab - typing url, and then pressing enter - Fixed the error explained above - A bit of formatting - Use the api v2 url
- You can see your task - If you do not have uncompleted ones the blocks do not display - Make the popup a bit wider for the scroll bar - Added some <hr> tags to space things nicely
- Sorry for the small commits, just trying to tweak for the pull request.
mother of god.... this will make people so happy, I'll check into this soon as I can |
There is still a bug when you middle click and open a new tab it does not check the url/what type of website it is. I am heading to bed, probably will not have time till the weekend to work on this. Hope it is up to the standard you have. |
@goldbattle I'm gonna merge this and play with it in coming days. I'll let you know if I hit any hitches, but this project is so unkempt it can't afford my bottlenecking in code review. If all's well, I'll deploy and set you as a project collaborator so you can direct-commit. What's your UUID for contrib reward, @deilann can you do the honors? |
o7 On Thu, May 1, 2014 at 12:09 PM, Tyler Renelle notifications@github.comwrote:
|
Anyone else want to help test this:
|
If I have time this weekend I will add some more. Finals are coming up so school is a priority right now. I will see what I can get done. I really want to get it so you can interact from the extension. Thank you!
|
lvl++ !! On Thu, May 1, 2014 at 1:52 PM, goldbattle notifications@github.com wrote:
|
Basic usage seems to be working for me so far. |
Likewise, will deploy hopefully today
|
@goldbattle thanks so much for this PR. I've been using it for the last few days and all's well - we've pushed live as v2.1. I've made you a repo admin, feel free to direct-commit hotfixes and basic things. For bigger changes, or things you'd like a code review on, send PRs. |
@goldbattle I'm gonna contrib.lvl++ you again, this was a pretty big contrib |
My goodness, goldbattle, thank you so much for this much-needed update! This is amazing! :D Has the update been pushed to the Chrome Web Store already? |
Yeah, thanks goldbrother! (esp. funny to me since a co-founder ref'd you as goldbetter) Yes, update's live at 2.1 |
Hello, I have just started using the main website and this chrome extension is important to me to be working. I use it as I use the stayfocus extension. I have read through the issues and saw that nobody has the time to give this any love. So I started updating it and working on it. Currently it is in a better state then I downloaded it in. Please see the list below:
Issues that shouldn't be an issue:
A screenshot of the updated styles. Using full bootstrap 3 instead of colored blocks etc.
Let me know what you think. I need to continue and update the todo integration as that was broken and I have not had time yet to work on it. I am going to try to allow for complete interaction inside the extension so a user does not have to go to the HabitRPG website or have the HabitRPG open in a pinned tab. Let me know what you think. Great project, and I like how this is all open source.
My todos I want to get done: