Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frequency to habits #8

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Add frequency to habits #8

merged 1 commit into from
Mar 1, 2020

Conversation

Majed6
Copy link
Contributor

@Majed6 Majed6 commented Feb 24, 2020

Close Issue 6

@Alys
Copy link
Contributor

Alys commented Feb 24, 2020

Thanks for this! I'll try to get it reviewed and merged this week. If it's still waiting this time next week, please remind me!

@Alys Alys merged commit 6c3c985 into HabitRPG:master Mar 1, 2020
@Alys
Copy link
Contributor

Alys commented Mar 1, 2020

Thank you! Tier 2 awarded. I'll post here when this has been pushed to Zapier, which I'm hoping I can do in a day or two.

@Majed6
Copy link
Contributor Author

Majed6 commented Mar 1, 2020

Yipee! Thanks a lot for the merge and the award.

@Alys
Copy link
Contributor

Alys commented Mar 8, 2020

That's live now in version 2.2.1 of the Habitica Beta. Thanks again!

@Majed6
Copy link
Contributor Author

Majed6 commented Mar 8, 2020

@Alys and the team Would you be interested in a continuous deployment pipeline ? Something like Deploy to Zapier when I tag a commit as ver:XXXX . Would be enjoyable to do. Just give me the conditions on which to deploy.

In Zapier we have the following important actions:

  • push : Build and upload the current app (Build).
  • promote : Promotes a specific version to public access.
    • Not currently relevant since we're still on beta stage.
  • migrate : Migrates users from one version of your app to another. Can be done with percent of users
  • deprecate : Marks a non-production version of your app as deprecated, with removal by a certain date.

How would you like to manage these actions? Could be as simple as "When I tag a commit with a version, push to Zapier" or as complex as:

  • Push on commit version tag and Migrate 20% of users to the new version
  • Promote latest tag on release branch push
  • Deprecate when promoting from major to major tag.

I suggest starting simple and as soon as we have a clearer picture of the integration change/adoption rate, we could get more complex.

@Majed6 Majed6 deleted the add_frequency branch March 8, 2020 11:57
@Alys
Copy link
Contributor

Alys commented Mar 9, 2020

I think that's a lovely idea! Thank you for offering! I think initially it would be best to keep it simple as you suggest and do "When I tag a commit with a version, push to Zapier". That's a safe action as it wouldn't affect any existing users.

@paglias What do you think?

@paglias
Copy link
Contributor

paglias commented Mar 9, 2020

starting with push looks like a good idea, @Majed6 let us know if you need anything done from us to set it up

@Alys Alys mentioned this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow frequency to be specified for Habits
3 participants