Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golden rock mount body sprite #8650

Closed
wants to merge 1 commit into from
Closed

Replace golden rock mount body sprite #8650

wants to merge 1 commit into from

Conversation

CooperFLe
Copy link

@CooperFLe CooperFLe commented Apr 4, 2017

Fixes #8647

Changes

Update golden rock mount body sprite to remove stray pixel
floating_pixel
fixed_mount


UUID: 9a4525a5-fc2b-4e0e-b687-140d8ae6b3bd

@coveralls
Copy link

coveralls commented Apr 4, 2017

Coverage Status

Coverage remained the same at 75.917% when pulling cccf6c5 on CooperFLe:develop into 7c516b7 on HabitRPG:develop.

@SabreCat SabreCat self-requested a review April 4, 2017 18:56
@paglias
Copy link
Contributor

paglias commented Apr 4, 2017

@SabreCat do we want spritesheets to be recompiled in PRs or we do it when we release a new version?

@SabreCat
Copy link
Member

SabreCat commented Apr 4, 2017

@paglias It's kinda inconsequential, especially when there are only a couple of files changed as here. In general I would say no, don't recompile spritesheets in PRs.

Copy link
Member

@SabreCat SabreCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, no need to commit compiled spritesheets. This will be OK as is, though!

@SabreCat
Copy link
Member

SabreCat commented Apr 4, 2017

@CooperFLe I'm merging this with today's content deploy (branch https://github.com/HabitRPG/habitica/tree/sabrecat/bgs-armoire-1704). Welcome to contributor tier 1! Note that subsequent tiers require increasing amounts of effort from one to the next, so tier 2 will require multiple PRs or a more substantial PR to attain. But keep helping out and we will express our gratitude accordingly!

@SabreCat SabreCat closed this Apr 4, 2017
@CooperFLe
Copy link
Author

Thank you for that! I had to recompile the spritesheet to make sure that the issue was resolved, was not aware that it was recompiling it was preferred, I am sorry for that.

I definitely will continue contributing! I want to contribute actual code to the project instead of just updating images soon!

@SabreCat
Copy link
Member

SabreCat commented Apr 4, 2017

@CooperFLe Yeah, no problem! You absolutely need to recompile the sheets for local testing, but it's not necessary to commit them to the PR. (Such changes will get overwritten the next time we add content anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golden Rock Mount Sprite Fix
4 participants