-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace golden rock mount body sprite #8650
Conversation
@SabreCat do we want spritesheets to be recompiled in PRs or we do it when we release a new version? |
@paglias It's kinda inconsequential, especially when there are only a couple of files changed as here. In general I would say no, don't recompile spritesheets in PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, no need to commit compiled spritesheets. This will be OK as is, though!
@CooperFLe I'm merging this with today's content deploy (branch https://github.com/HabitRPG/habitica/tree/sabrecat/bgs-armoire-1704). Welcome to contributor tier 1! Note that subsequent tiers require increasing amounts of effort from one to the next, so tier 2 will require multiple PRs or a more substantial PR to attain. But keep helping out and we will express our gratitude accordingly! |
Thank you for that! I had to recompile the spritesheet to make sure that the issue was resolved, was not aware that it was recompiling it was preferred, I am sorry for that. I definitely will continue contributing! I want to contribute actual code to the project instead of just updating images soon! |
@CooperFLe Yeah, no problem! You absolutely need to recompile the sheets for local testing, but it's not necessary to commit them to the PR. (Such changes will get overwritten the next time we add content anyway.) |
Fixes #8647
Changes
Update golden rock mount body sprite to remove stray pixel
UUID: 9a4525a5-fc2b-4e0e-b687-140d8ae6b3bd