-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notifications #4279
Comments
some implementation notes. socket.io was the popular option last I checked (for web); we'd need to optimize what specifically is being watched for for groups / user modifications subscriptions. We'll want to make sure socket.io server-side won't bring us to a crawl. I'm not sure what to use Phonegap-side |
WHOOPS, found the ticket - I knew I'd posted one! It's under "mobile" - Should I close this one, or keep it open for discussion of how we might do On Tue, Nov 25, 2014 at 2:22 PM, Tyler Renelle notifications@github.com
|
@lefnire @lemoness I've asked the guy there if he's still working on it. Phonegap seems to have a few plugins that may help us. I would like to have a better overview of what type of notifications we want to habdle with this: Reminder for missed dailies/haven't used habit today...The easiest one, we just need to track access to the website, something like lastOp or lastAccess Invitations, private messages and new chat messagesThis one instead is more complicate. In theory we wouldn't need socket.io, we could try to notify the user with a mobile notification when an invitation/new private message is sent. And that's the easy way. But for example it won't work on the website, won't consider when the user is online so it would be better to have a notification inside the app... To have the situations above working we can follow 2 paths:
This is easier. We keep using the API as always and use SSE to notify users when necessary. It's like websockets but only server->browser not 2 way communication. The browser connects to the server that keeps a connection open where messages can be sent. It opens a new connection for every connected user so I'm not sure how heavy is going to be.
While keeping the api active we would have to migrate the server<->browser communication to use socket.io, it's going to make habitrpg realtime but also a bit complicate to implement. I think that for both solutions the biggest problem is going to be performances. We would have to keep in memory a representation of all the users connected but mostly of their "dependencies" especially if we want to make realtime chats. I don't know... I think we should first carefully research the features we want to implement before taking any decision. |
@negue Do you know if this can be closed? Or is it still needed for more work to be done? |
|
This issue was posted before the new native apps were in development, and most of the comments are probably irrelevant for the new apps, so I'm closing this. |
I thought I'd already opened this ticket, but I couldn't find it, so here it is!
It would be great to have push notifications on the mobile app,as well as possibly on the website.
However, there are still a few points to discuss. When should we send them? How frequently? To what extent should users be able to control them? (Obviously, you'd need to be able to opt-out.)
I'm in favor of a Settings panel that lets you choose what time(s) you'd get push notifications if you still had incomplete Dailies, as well as for other events like a quest invite, etc.
There are lots of things we can do with this feature, so let's hear some ideas and strategies!
The text was updated successfully, but these errors were encountered: