Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admission service #101

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Add admission service #101

merged 19 commits into from
Oct 31, 2023

Conversation

npunati27
Copy link
Contributor

admission service, get and put requests.

Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is good, some more little JS errors!

Also, could you add some tests for this file (reference changes made in #89 )

package-lock.json Outdated Show resolved Hide resolved
src/services/admission/admission-formats.ts Outdated Show resolved Hide resolved
src/services/admission/admission-formats.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
@AydanPirani
Copy link
Contributor

@npunati27 One more thing, please don't forget to update docs!

Copy link
Member

@Timothy-Gonzalez Timothy-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good. A few things to consider.

Also, due to recent changes, you'll have to merge in the changes from main, which mainly consists of StatusCode being added (#106), so your code will have to be updated to use that instead. Also, tests will then use StatusCode.SuccessOK instead of 200 etc.

src/services/admission/admission-router.test.ts Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Timothy-Gonzalez Timothy-Gonzalez changed the title Dev/nikhita/decisionmvp Add admission service Oct 25, 2023
@AydanPirani AydanPirani self-requested a review October 29, 2023 17:01
Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just make those small changes, and then we should be good to go

.gitignore Outdated Show resolved Hide resolved
src/services/admission/admission-formats.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
Copy link
Member

@Timothy-Gonzalez Timothy-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! A few minor changes to be made to make tests & router a little cleaner.

src/services/admission/admission-router.ts Show resolved Hide resolved
src/services/admission/admission-router.test.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.test.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.test.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
Copy link
Member

@Timothy-Gonzalez Timothy-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! My only comments left are minor nps & cleaning up some of the stuff from earlier. Code wise, you're golden! By the way, I'm sorry for being pretty strict with these tests but I think it will help preserve the usability of them for years to come.

.gitignore Outdated Show resolved Hide resolved
src/services/admission/admission-formats.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.test.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
Copy link
Member

@Timothy-Gonzalez Timothy-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to merge whenever!

Note: when merging, do a squash merge (from GitHub UI), and edit the description to have only relevant changes. For example, something like "Add GET and PUT endpoints" is good but something like "fix nitpicks" doesn't need to be in the merge description.

@npunati27 npunati27 merged commit 1e442f4 into main Oct 31, 2023
5 checks passed
@npunati27 npunati27 deleted the dev/nikhita/decisionMVP branch October 31, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants