Move constants & env to central config #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version only used .env files, this allows for the local env variables set in a terminal for example to override the ones in the .env files
AydanPirani
approved these changes
Nov 3, 2023
|
Don't merge yet, preview 500s |
Timothy-Gonzalez
added a commit
that referenced
this pull request
Nov 5, 2023
Merged
Timothy-Gonzalez
added a commit
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #90
This PR moves all usages of
process.env.*to a centralconfig.tsfile which replaces the oldconstants.tsfile. Also, instead of having a arbitrary class, it is now a pure JS object, so it's much easier to edit and use.This allows us to remove the temporary
database/getBaseUrl.tsand as such refactors test mocks to work alongside the new changes.I haven't verified everything works, but tests do pass so the bare minimum at least does. Should test auth to verify this doesn't brick anything.