Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/alex/resume upload get #140

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Dev/alex/resume upload get #140

merged 4 commits into from
Jan 12, 2024

Conversation

aletya
Copy link
Contributor

@aletya aletya commented Jan 10, 2024 •
edited

added /s3 route to app.ts
added endpoints to get presigned urls

  • GET /s3/upload
  • GET /s3/download
  • GET /s3/download/:USERID
    **added aws-sdk to yarn
    **added 4 lines to config.ts for 4 new env variables

@AydanPirani AydanPirani self-requested a review January 12, 2024 00:42
AydanPirani
AydanPirani approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AydanPirani AydanPirani merged commit 7cc95ed into main Jan 12, 2024
5 checks passed
@AydanPirani AydanPirani deleted the dev/alex/resume-upload-get branch January 12, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AydanPirani AydanPirani AydanPirani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aletya @AydanPirani