Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve registration tests & add /submit/ tests #171

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Improve registration tests & add /submit/ tests #171

merged 3 commits into from
Jan 23, 2024

Conversation

Timothy-Gonzalez
Copy link
Member

  • Clean up current tests
  • Add POST /registration/submit/ tests

@Timothy-Gonzalez
Improve general application
ebdfc9e 
Pass actual data
@Timothy-Gonzalez
Clean up current tests
5ce61cd
@Timothy-Gonzalez
Add tests for POST /registration/submit/
b50c68f 
Also refactors router to make it easier to mock sendMail, and return
better response value
@Timothy-Gonzalez Timothy-Gonzalez self-assigned this Jan 23, 2024
@lasyaneti lasyaneti mentioned this pull request Jan 23, 2024
Merged
@lasyaneti lasyaneti self-requested a review January 23, 2024 08:42
@lasyaneti lasyaneti merged commit e3a628b into main Jan 23, 2024
5 checks passed
@lasyaneti lasyaneti deleted the dev/improve-registration-tests branch January 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasyaneti lasyaneti lasyaneti approved these changes

@AydanPirani AydanPirani Awaiting requested review from AydanPirani

Assignees

@Timothy-Gonzalez Timothy-Gonzalez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timothy-Gonzalez @lasyaneti