Event attend #79
Merged
Event attend #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjrb
pushed a commit
that referenced
this pull request
Sep 25, 2019
* matching qr code to hackers * Implement a script to generate QR codes with various options * Convert to use pixels and top left corner setting * added qr Matching test file * Provide defaults for label printing * Event attend (#79) * add attend function * move event_attend to qrscan * reopen registration? * temporarily use tabs and fix errors found in testing * move attend event into qrcode.py * reorg imports, fix minor setup bug, add attend test * dont need that import * fix spacing * remove todos * add the 2 new endpoints * used the ensure_role decorator * fixed my test_qr_matching * Forgot one qrMatch * body now return sucess * remove comment
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think your editor is setup for tabs, but the rest of the codebase uses 4 spaces. python can get a bit pedantic so i used tabs here. after this merges i can reformat it back to spaces if you wan't or you can do it. I decided to put my stuff in your qrcode file because they are sort of used in conjunction.
all the imports in the test file are the same but i just reorganized them to be alphabetical and broken into stdlib, vendor, us. let me know if there is anything that looks funny, or if I'm missing an edge case