Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #33

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update README.md #33

merged 2 commits into from
Apr 30, 2024

Conversation

yagmureva
Copy link
Collaborator

Description

Please provide a short summary explaining what this PR is about.

Fixes # (issue)

How to test?

Please provide a short summary how your changes can be tested?

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@yagmureva yagmureva requested a review from a team as a code owner April 29, 2024 20:21
shpomp
shpomp approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@shpomp shpomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

orhantoy
orhantoy reviewed Apr 30, 2024
View reviewed changes
README.md
Comment on lines +51 to +53
1. Clone the repository:
```bash
git clone https://github.com/HackYourFuture-CPH/team26-checkin.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation steps seem incomplete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I modified can you check again?

@yagmureva yagmureva merged commit 8cdb86f into main Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhantoy orhantoy orhantoy left review comments

@shpomp shpomp shpomp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yagmureva @orhantoy @shpomp