Add window constraint, move arrow when needed #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! We could probably work a little bit on the positioning of the element when it's positioned to the top, but that's future work. Can you fix the merge conflicts so I can merge your PR? |
Conflicts: dist/react-datepicker.min.js
|
@martijnrusschen Thanks! Agreed, this is essentially an minimum viable implementation for my use case. There's lots of room to leverage Tether to a greater extent. |
martijnrusschen
added a commit
that referenced
this pull request
Jul 8, 2015
Add window constraint, move arrow when needed
|
Thanks again, I'll look into it soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that I needed to add the window constraint to the popover to keep the datepicker on-screen when there's not enough space below the input. I also implemented styles to move the arrow to the bottom of the datepicker when the popover moves above the input (should resolve #29).
Note that Tether does not currently reverse offsets when the window constraint triggers (see shipshapecode/tether#85): this means the arrow spacing will be inconsistent between the two states.