Feature/AppHeader/Bakhat #35
Conversation
|
I added header component in AppHeader.jsx |
| // what goes in here? there is no content in the AppHeader component | ||
| // ); | ||
| // export default AppHeader; | ||
| import Logo from "@/assets/spa-logo.png"; |
There was a problem hiding this comment.
I believe that the correct file is hotel-logo.png rather than spa-logo.png, as we can see in the last step of the issue: "render the hotel's logo in an <img>".
…chResults Component/SearchRestults Implementation #35
|
Thank you Pedro I did change the logo. |
| // what goes in here? there is no content in the AppHeader component | ||
| // ); | ||
| // export default AppHeader; | ||
| import Logo from "@/assets/hotel-logo.png"; |
| <header className="app__header"> | ||
| <h1 className="app__heading">CYF Hotel</h1> | ||
| </header> | ||
| <AppHeader/> |
There was a problem hiding this comment.
Well done for this, you have successfully extracted appheader completing step1 +2 of the instructions
| const AppHeader = () => ( | ||
| <header className="app__header"> | ||
| <h1 className="app__heading">CYF Hotel</h1> | ||
| <img src={Logo} alt="main image" /> |
There was a problem hiding this comment.
This alt text is not descriptive at all.
When writing alt text, try to imagine a blind person listening to it. Does it accurately descibe the image ?
| // what goes in here? there is no content in the AppHeader component | ||
| // ); | ||
| // export default AppHeader; | ||
| import Logo from "@/assets/hotel-logo.png"; |
There was a problem hiding this comment.
good use of the @ symbol here for imports
| return true; | ||
| }); | ||
|
|
||
| test('renders AppHeader component', () => { |
There was a problem hiding this comment.
using test here is fine, but it looks inconsistent using "test" in one section and "it" in another. It is always best to be consistent with your code
|
It is also best to keep your PRs consistent without saying who did what specifically as this is a collaborative project |
Learners, PR Template
Self checklist
Changelist
I added header component.
Questions