Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #8

Closed
3 tasks done
HadrienG opened this issue May 11, 2017 · 1 comment
Closed
3 tasks done

Refactoring #8

HadrienG opened this issue May 11, 2017 · 1 comment
Assignees
Milestone

Comments

@HadrienG
Copy link
Owner

HadrienG commented May 11, 2017

Issue to track the progress on the Roadmap item "Refactor to avoid duplicated code when possible"

Some functions are duplicated at the moment, and the bam parsing and model creation is quite messy.

  • There are duplicated functions in the error model classes. The indels and substitutions functions can probably be moved to the base ErrorModel class
  • Ideally a bam file should only be read once to create the model .npz file. It is not the case now.
  • Some functions are too long (notably in bam.py) and should be broken done into smaller functions. Possibly the bam.py file could even be split in 2 files (perhaps 1 general bam reading / writing and 1 where the heavy lifting / model creation happens)
@HadrienG HadrienG self-assigned this May 11, 2017
@HadrienG HadrienG added this to the 0.1.0-alpha milestone May 11, 2017
@HadrienG HadrienG mentioned this issue May 11, 2017
20 tasks
@HadrienG
Copy link
Owner Author

closed with ba7ef2d

HadrienG pushed a commit that referenced this issue Oct 6, 2023
Update master with upstream changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant