Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: Add SOVERSION for libsrt #67

Merged
merged 1 commit into from
Jul 22, 2017

Conversation

justinjoy
Copy link
Contributor

Signed-off-by: Justin Kim justin.kim@collabora.com

@ethouris
Copy link
Collaborator

Well... how's that possible that just adding a small property has caused build break on Windows?

@justinjoy : have you checked how it works in both modes - with haicrypt+srt in one library file and in two separate files?

@justinjoy
Copy link
Contributor Author

@justinjoy : have you checked how it works in both modes - with haicrypt+srt in one library file and in two separate files?

I missed the separating option. For both cases, they work in linux environment.
However, in CI, it seems to use a different version of OpenSSL because I can see the below log in the middle of CI report.

C:\projects\srt\haicrypt\hc_openssl_aes.c(267): warning C4013: 'AES_ctr128_encrypt' undefined; assuming extern returning int [C:\projects\srt\srt.vcxproj]

The function, AES_ctr128_encrypt, has disappeared in OpenSSL-1.1, but I'm not sure.

@rndi
Copy link
Collaborator

rndi commented Jul 21, 2017

Hello @justinjoy , could you please try updating your branch with the latest to see if CI passes this time? Thank you!

Signed-off-by: Justin Kim <justin.kim@collabora.com>
@rndi rndi merged commit 7607d70 into Haivision:master Jul 22, 2017
@justinjoy justinjoy deleted the pr/soname branch October 13, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants