Allow files bigger than 64MiB

[tmplt]

Presently, a 64MiB file size limit is hard coded. I presume https://ptpb.pw doesn't allow anything larger? I'd like to upload files bigger than that on my own pb deployment.

[HalosGhost]

That is correct; however, if memory serves, this limit is actually partially due to an inherent limit in pb's stack—i.e., I am not sure you actually can have a pb deployment which allows larger files.

I will go ahead and add a configure option for setting the max file size; that way, it is easy to change at compile-time in case pb ever can do larger files. Does that sounds good?

[tmplt]

The limit must have been fixed/removed; I just uploaded a 100M file on my own deployment. I had to change my nginx.conf first, though.

I will go ahead and add a configure option for setting the max file size [...]

That would be great, unless it is possible to check if the server would accept the file first? I tried uploading a file which was too large before, but curl didn't error out until the limit had been reached. Is it possible to check before uploading?

[HalosGhost]

In an ideal world, there would be a route that pb would offer which would tell you the max file size it would accept; then I would not hard-code it, but instead (when the db is first initialized, or a provider is set through the upcoming --set-provider option) call out to the provider to get the max file size.

However, no such route exists at the moment that I know of. I already have the change staged on my side (very small change really) to add the configure option; I will push it tonight.

[HalosGhost]

via d88ba02

[HalosGhost]

@tmplt, I have added a page to the wiki to informally track pb instances. Would you care to add your instance to the list (or are you hoping to keep it private)?

[tmplt]

@HalosGhost at present I'm keeping it private. I might add it when I figure out how to remove files after some time, depending on their file size.

[HalosGhost]

No worries! If you know of any other pb instances which are public (or you ever decide to open your instance for public use), please feel free to add them to the wiki!

[tmplt]

I'll do that. Perhaps a column could be added for maximum allowed file size?

On 10/18/2016 02:34 PM, Sam Stuewe wrote:

No worries! If you know of any other pb instances which are public (or
you ever decide to open your instance for public use), please feel free
to add them to the wiki!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#71 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF1cyhFTp0iek2V5m3tVJN7Mi2gH-A37ks5q1LzagaJpZM4KCP2p.

[HalosGhost]

It's a wiki, feel free to add whatever information you feel is pertinent 😄