Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional runtime error detection options are now enabled. #2760

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

cmsj
Copy link
Member

@cmsj cmsj commented Mar 11, 2021

No description provided.

…since we're already running Address Sanitiser and thus taking its performance hit
@cmsj cmsj added this to the 0.9.85 milestone Mar 11, 2021
@cmsj cmsj added the pr-maintenance Pull Request for uninteresting maintenance work label Mar 11, 2021
@cmsj cmsj self-assigned this Mar 11, 2021
@github-actions
Copy link

Release Notes Preview

Fixed

  • A potential crash in hs.chooser has been guarded against
  • Fix hs.window:snapshot() transparency option. Closes [Bug] hsWindow:snapshot(true) gives error #2742
  • hs.window:isVisible() will now return false even if the underlying hs.application object is invalid
  • hs.window.desktop() now returns nil if Finder is not running
  • Several potential out-of-bounds crashes in hs.canvas have been guarded against.
  • A crash in hs.fs.volume watchers has been guarded against
  • A crash in hs.webview is now guarded by an experimental protection method
  • A crash bug in hs.settings was fixed. #2753

Changed

  • Another damaged installation case is now a user-visible error and not a silent crash.
  • Fix some errors found via Xcode static analysis

Other:

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2760 (e644342) into master (1d29cef) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   26.93%   26.80%   -0.14%     
==========================================
  Files         178      178              
  Lines       35808    35968     +160     
==========================================
- Hits         9646     9641       -5     
- Misses      26162    26327     +165     

@github-actions

This comment has been minimized.

@cmsj cmsj merged commit 2b44d78 into master Mar 11, 2021
@github-actions
Copy link

View Test Results

    1 files  ±0    26 suites  ±0   4m 12s ⏱️ ±0s
320 tests ±0  320 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2b44d78. ± Comparison against base commit 2b44d78.

@cmsj cmsj deleted the enable-more-sanity branch March 11, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-maintenance Pull Request for uninteresting maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant