Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing background in MODERN and SIMPLE SECTION skins. #86

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Missing background in MODERN and SIMPLE SECTION skins. #86

wants to merge 8 commits into from

Conversation

claudio-rosati
Copy link
Contributor

No description provided.

@claudio-rosati
Copy link
Contributor Author

Here how MODERN will look like using all Color.DARKxxx colors.

modern

@claudio-rosati
Copy link
Contributor Author

@HanSolo what do you think about this pull request?

Claudio Rosati added 2 commits February 21, 2017 08:54
Merge remote-tracking branch 'HanSolo/master' into missing-background…
b1f2a05 
…-in-MODERN-and-SIMPLE_SECTION-skins

# Conflicts:
#	src/main/java/eu/hansolo/medusa/Test.java
Merge remote-tracking branch 'origin/missing-background-in-MODERN-and…
613f33a 
…-SIMPLE_SECTION-skins' into missing-background-in-MODERN-and-SIMPLE_SECTION-skins
@HanSolo
Copy link
Owner

HanSolo commented Feb 21, 2017

To be honest I do not really like it because the skin was not meant to be modified like this, so I guess I won't add it.

@claudio-rosati
Copy link
Contributor Author

I understand.
My problems here is that all the gauges I allow in my product (a subset of the Medusa ones) must have the same properties, otherwise the final users will not understand why, for example, changing the background will not result in a visible change for some gauges.
Today or, more probably, tomorrow I'll send you a private message about this and how I think to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudio-rosati @HanSolo