Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle Ordering set in Subtitle Selection behavior is no longer being applied since version 1.6.1 #5590

Closed
JesseWBDL opened this issue Dec 14, 2023 · 1 comment
Labels
Milestone

Comments

@JesseWBDL
Copy link

Problem Description

All versions of Handbrake since 1.6.1 don't seem to apply the default selection behavior for subtitles. This can be reproduced as follows:

  1. Using Version 1.7.1 or 1.7.0
  2. Use a Video file that contains multiple subtitle languages in my case I used an MP4 with AVC video encoding / AAC audio and numerous embedded tx3g subtitles (I will include the NFO data at the bottom).
  3. I Set up a Subtitle Selection criteria that would ensure English was at the top and "Any" was second. I Set the Track Selection Behaviour to "All Matching Selected Languages"
  4. I drag in the video file
  5. My Selected language just appears randomly in the subtitle tab not at the top as expected

I rolled back to 1.6.1 and this functionality works perfectly
image

image

MP4FileUsedNFO.txt

Activity Log, Crash Log or any other details

HandBrake 1.7.0 (2023111500)
OS: Microsoft Windows NT 10.0.19045.0
CPU: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
Ram: 8080 MB, 
GPU Information:
  Intel(R) HD Graphics 530 - 31.0.101.2111
  Microsoft Remote Display Adapter - 10.0.19041.3636
Screen: 2560x1440
Temp Dir: C:\Users\bob\AppData\Local\Temp\
Install Dir: C:\Program Files\HandBrake\
Data Dir: C:\Users\bob\AppData\Roaming\HandBrake

-------------------------------------------
[14:20:26] hb_init: starting libhb thread

 # Starting Scan ...

[14:20:26] CPU: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
[14:20:26]  - Intel microarchitecture Skylake
[14:20:26]  - logical processor count: 4
[14:20:26] Intel Quick Sync Video support: yes, gpu list: 0, 1
[14:20:26] Intel Quick Sync Video integrated adapter with index 0
[14:20:26] Impl mfxhw64 library path: C:\WINDOWS\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_51f685305808e3a5\libmfxhw64.dll
[14:20:26]  - Intel Media SDK hardware: API 1.35 (minimum: 1.3)
[14:20:26]  - Decode support:  h264 hevc (8bit: yes, 10bit: no)
[14:20:26]  - H.264 encoder: yes
[14:20:26]     - preferred implementation: hardware (1) via D3D11
[14:20:26]     - capabilities (hardware):  breftype icq+la+i+downs vsinfo chromalocinfo opt1 opt2+mbbrc+extbrc+trellis+repeatpps+ib_adapt+nmpslice
[14:20:26]  - H.265 encoder: yes (8bit: yes, 10bit: no)
[14:20:26]     - preferred implementation: hardware (1) via D3D11
[14:20:26]     - capabilities (hardware):  bpyramid icq vsinfo masteringinfo cllinfo opt1
[14:20:26]  - AV1 encoder: no
[14:20:26] Intel Quick Sync Video integrated adapter with index 1
[14:20:26] Impl mfxhw64 library path: C:\WINDOWS\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_51f685305808e3a5\libmfxhw64.dll
[14:20:26]  - Intel Media SDK hardware: API 1.35 (minimum: 1.3)
[14:20:26]  - Decode support:  h264 hevc (8bit: yes, 10bit: no)
[14:20:26]  - H.264 encoder: yes
[14:20:27]     - preferred implementation: hardware (2) via D3D11
[14:20:27]     - capabilities (hardware):  breftype icq+la+i+downs vsinfo chromalocinfo opt1 opt2+mbbrc+extbrc+trellis+repeatpps+ib_adapt+nmpslice
[14:20:27]  - H.265 encoder: yes (8bit: yes, 10bit: no)
[14:20:27]     - preferred implementation: hardware (2) via D3D11
[14:20:27]     - capabilities (hardware):  bpyramid icq vsinfo masteringinfo cllinfo opt1
[14:20:27]  - AV1 encoder: no
[14:20:27] hb_scan: path=C:\Downloads\TVShows\Destined (2023)\Destined.S01E11.2023.1080p.IQIYI.WEB-DL.AAC.H.264-ANDY.mp4, title_index=0
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'C:\Downloads\TVShows\Destined (2023)\Destined.S01E11.2023.1080p.IQIYI.WEB-DL.AAC.H.264-ANDY.mp4':
  Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2avc1mp41
    encoder         : ANDY
  Duration: 00:46:09.84, start: 0.000000, bitrate: 2018 kb/s
  Stream #0:0[0x1](und): Video: h264 (High) (avc1 / 0x31637661), yuv420p(tv, bt709, progressive), 1920x800, 1818 kb/s, 25 fps, 25 tbr, 90k tbn (default)
    Metadata:
      handler_name    : VideoHandler
      vendor_id       : [0][0][0][0]
  Stream #0:1[0x2](chi): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 191 kb/s (default)
    Metadata:
      handler_name    : SoundHandler
      vendor_id       : [0][0][0][0]
      title           : Mandarin
  Stream #0:2[0x3](chi): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s (default)
    Metadata:
      handler_name    : SubtitleHandler
      title           : Simplified Chinese
  Stream #0:3[0x4](chi): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Traditional Chinese
  Stream #0:4[0x5](eng): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : English
  Stream #0:5[0x6](kor): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Korean
  Stream #0:6[0x7](tha): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Thai
  Stream #0:7[0x8](may): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Bahasa Malaysia
  Stream #0:8[0x9](vie): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Vietnamese
  Stream #0:9[0xa](ind): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Bahasa Indonesia
  Stream #0:10[0xb](spa): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Spanish
  Stream #0:11[0xc](ara): Subtitle: mov_text (tx3g / 0x67337874), 0 kb/s
    Metadata:
      handler_name    : SubtitleHandler
      title           : Arabic
[14:20:27] scan: decoding previews for title 1
[14:20:27] scan: audio 0x1: aac, rate=44100Hz, bitrate=191977 ?? (AAC LC, 2.0 ch, 191 kbps)
[14:20:27] scan: 10 previews, 1920x800, 25.000 fps, autocrop = 2/2/0/0, aspect 2.40:1, PAR 1:1, color profile: 1-1-1, chroma location: left
[14:20:27] scan: supported video decoders: avcodec qsv
[14:20:27] libhb: scan thread found 1 valid title(s)

 # Scan Finished ...

What Operating System are you running?

Windows 10

What version of HandBrake are you running?

1.7.1

Where did you download HandBrake from?

Within the App update feature

@sr55 sr55 added the Bug label Dec 18, 2023
@sr55 sr55 added this to the 1.7.2 milestone Dec 18, 2023
sr55 added a commit that referenced this issue Dec 18, 2023
@sr55
Copy link
Contributor

sr55 commented Dec 18, 2023

Thanks for the report.
I've pushed a fix so that it should now honour the language order again.

This will be part of 1.7.2 and be available in the development snapshot builds later this week.

@sr55 sr55 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants