Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quote insert handler #1429

Merged
merged 1 commit into from
May 19, 2020
Merged

Improve quote insert handler #1429

merged 1 commit into from
May 19, 2020

Conversation

PHPirates
Copy link
Collaborator

Fixes #1425

Summary of additions and changes

  • Don't replace quotes after a backslash, so you can always type \"
  • Handle insertion at end of document properly
  • Assume opening quotes are needed for csquotes whenever a close brace is not next

How to test this pull request

test typing \enquote{quoted} text and ``ligatures'' and \lq\lq{}commands\rq\rq{} and "offf"

Wiki

  • Updated the wiki

@PHPirates PHPirates added this to the b0.6.10 milestone May 19, 2020
@PHPirates PHPirates self-assigned this May 19, 2020
@HannahSchellekens HannahSchellekens merged commit 6b8cdc4 into master May 19, 2020
@HannahSchellekens HannahSchellekens deleted the quotes branch May 19, 2020 19:11
HannahSchellekens added a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot insert quotes sometimes & crash with csquotes smart quotes
3 participants