Remove casts unnecessary since ResourceDescriptor parameterization

HannesWell · Jul 1, 2023 · ed5fb60 · ed5fb60
1 parent dd35c4f
commit ed5fb60
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ImageResourceManager.java b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ImageResourceManager.java
@@ -55,7 +55,7 @@ static ImageDescriptor getImageDescriptor(String path) {
 	 * @return the image
 	 */
 	Image getImage(ImageDescriptor descriptor) {
-		return (Image) manager.get(descriptor);
+		return manager.get(descriptor);
 	}
 }
 
diff --git a/...les/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java b/...les/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java
@@ -42,7 +42,6 @@
 import org.eclipse.osgi.util.TextProcessor;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.graphics.Font;
-import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.layout.RowLayout;
@@ -279,7 +278,7 @@ protected Control createDialogArea(Composite parent) {
 			return TextProcessor.process(d.getLabel(), "."); //$NON-NLS-1$
 		}, element -> {
 			IEditorDescriptor d = (IEditorDescriptor) element;
-			return (Image) resourceManager.get(d.getImageDescriptor());
+			return resourceManager.get(d.getImageDescriptor());
 		}));
 
 		browseExternalEditorsButton = new Button(contents, SWT.PUSH);

diff --git a/...ipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetLabelProvider.java b/...ipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetLabelProvider.java
@@ -46,7 +46,7 @@ public Image getImage(Object object) {
 		IWorkingSet workingSet = (IWorkingSet) object;
 		ImageDescriptor imageDescriptor = workingSet.getImageDescriptor();
 
-		return imageDescriptor == null ? null : (Image) images.get(imageDescriptor);
+		return imageDescriptor == null ? null : images.get(imageDescriptor);
 	}
 
 	@Override

diff --git a/...g.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetTypePage.java b/...g.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetTypePage.java
@@ -127,7 +127,7 @@ public void dispose() {
 			@Override
 			public Image getImage(Object element) {
 				ImageDescriptor imageDescriptor = ((WorkingSetDescriptor) element).getIcon();
-				return imageDescriptor == null ? null : (Image) images.get(imageDescriptor);
+				return imageDescriptor == null ? null : images.get(imageDescriptor);
 			}
 		});
 		typesListViewer.setInput(descriptors);

diff --git a/...eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessEntry.java b/...eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessEntry.java
@@ -129,7 +129,7 @@ private Image findOrCreateImage(ImageDescriptor imageDescriptor, ResourceManager
 		if (imageDescriptor == null) {
 			return null;
 		}
-		Image image = (Image) resourceManager.find(imageDescriptor);
+		Image image = resourceManager.find(imageDescriptor);
 		if (image == null) {
 			try {
 				image = resourceManager.createImage(imageDescriptor);

diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/model/WorkbenchLabelProvider.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/model/WorkbenchLabelProvider.java
@@ -182,7 +182,7 @@ public final Image getImage(Object element) {
 		// add any annotations to the image descriptor
 		descriptor = decorateImage(descriptor, element);
 
-		return (Image) getResourceManager().get(descriptor);
+		return getResourceManager().get(descriptor);
 	}
 
 	/**
@@ -263,7 +263,7 @@ public Font getFont(Object element) {
 			return null;
 		}
 
-		return (Font) getResourceManager().get(FontDescriptor.createFrom(descriptor));
+		return getResourceManager().get(FontDescriptor.createFrom(descriptor));
 	}
 
 	private Color getColor(Object element, boolean forground) {
@@ -276,6 +276,6 @@ private Color getColor(Object element, boolean forground) {
 			return null;
 		}
 
-		return (Color) getResourceManager().get(ColorDescriptor.createFrom(descriptor));
+		return getResourceManager().get(ColorDescriptor.createFrom(descriptor));
 	}
 }