Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardians of the Galaxy RT shaders cause segfault during conversion #134

Closed
pixelcluster opened this issue Nov 23, 2022 · 1 comment · Fixed by #144
Closed

Guardians of the Galaxy RT shaders cause segfault during conversion #134

pixelcluster opened this issue Nov 23, 2022 · 1 comment · Fixed by #144

Comments

@pixelcluster
Copy link
Contributor

Faulting DXIL:
gotg_rt_crash_dxil.zip

Backtrace:

#0  0x00007ffff7e8adf6 in dxil_spv::CFGNode::dominates (this=0x555555dafff0, other=0x0) at node.cpp:95
#1  0x00007ffff7e631fc in dxil_spv::CFGStructurizer::find_switch_blocks (this=0x7fffffffb5d0, pass=0) at cfg_structurizer.cpp:2056
#2  0x00007ffff7e67318 in dxil_spv::CFGStructurizer::structurize (this=0x7fffffffb5d0, pass=0) at cfg_structurizer.cpp:3067
#3  0x00007ffff7e5c2d8 in dxil_spv::CFGStructurizer::run (this=0x7fffffffb5d0) at cfg_structurizer.cpp:382
#4  0x00007ffff7dfd2cd in dxil_spv_converter_run (converter=0x555555b85ea0) at dxil_spirv_c.cpp:531
#5  0x0000555555582628 in main (argc=2, argv=0x7fffffffdca8) at dxil_spirv.cpp:900
@SingleInfiniteLoop
Copy link

I've got similar crash (I assume) at the very same place when running Battlefield 2042:

			auto *dominated_merge_target = find_common_post_dominator_with_ignored_break(node->succ, merge);
			if (node->dominates(dominated_merge_target))

I suggest a simple fix like this:

			auto *dominated_merge_target = find_common_post_dominator_with_ignored_break(node->succ, merge);
			if (dominated_merge_target && node->dominates(dominated_merge_target))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants