This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
High quality icon #1107
Merged
High quality icon #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the icon, thank you! Also planning on re-doing settings before going live, will use the automatic heights |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very high-quality icon to the app.
It also shuffles the icon selection screen around a little so that it uses a subtitle style for denoting authors of community contributions. I also made it so that the cells use an automatic height, and properly grow with their text. That meant adding a
minHeightvariable toInsetCell. We should look at using this everywhere else in the settings so that we don't have any clipping.Finally, I added a quick shell script for making the images we need for a community icon out of a 1024x1024
.png.