Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke in the cabin #13

Closed
gilbertohasnofb opened this issue Jul 30, 2016 · 9 comments
Closed

Smoke in the cabin #13

gilbertohasnofb opened this issue Jul 30, 2016 · 9 comments

Comments

@gilbertohasnofb
Copy link
Collaborator

When cranking the engine during the engine startup, you can see 2D smoke inside the cabin. I would suggest two things:

  • use particle effects instead of 2D smoke
  • make these visible only if the view is not internal
@Harald67
Copy link
Owner

Harald67 commented Aug 6, 2016

I disabled smoke for now, this can be added later again.

@Harald67 Harald67 closed this as completed Aug 6, 2016
@gilbertohasnofb
Copy link
Collaborator Author

👍

@ghost
Copy link

ghost commented Aug 12, 2016

Is there at all smoke coming out when the engine is cranking? Never saw this (e.g. when flying the aircraft in RL)
see for example here: https://www.youtube.com/watch?v=qxjSAWeFwuo

@gilbertohasnofb
Copy link
Collaborator Author

Is there at all smoke coming out when the engine is cranking? Never saw this

There is never smoke in the cabin from cranking the engine, which is why this was reported as a bug and why we disabled it and closed this issue 😉

The smoke was supposed to be seen from outside only when starting the engine, but it was also seen inside the cabin. Anyway I think we will later implement smoke using the same particle effects that the c172p uses, it looks far better than using smoke images.

@ghost
Copy link

ghost commented Aug 12, 2016

i meant the smoke from the outside. as you see on the video there seems to
be none


Gesendet mit der Telekom Mail App
http://www.t-online.de/service/redir/email_app_android_sendmail_footer.htm

--- Original-Nachricht ---
Von: Gilberto Agostinho
Betreff: Re: [Harald67/c150] Smoke in the cabin (#13)
Datum: 12.08.2016, 14:50 Uhr
An: Harald67/c150
Cc: D-ECHO, Comment

Is there at all smoke coming out when the engine is cranking? Never saw
this

There is never smoke in the cabin from cranking the engine, which is why
this was reported as a bug and why we disabled it and closed this issue 😉

The smoke was supposed to be seen from outside only when starting the
engine, but it was also seen inside the cabin. Anyway I think we will later
implement smoke using the same particle effects that the c172p uses, it
looks far better than using smoke images.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#13 (comment) , or
mute the thread
https://github.com/notifications/unsubscribe-auth/ALtQ-C1v2peKXb1znUx5y4ZHS1Fw23nEks5qfGwNgaJpZM4JY3Me
.

@gilbertohasnofb
Copy link
Collaborator Author

@D-ECHO Ah, I see what you meant, sorry for misunderstanding it!

I think in certain situations there is smoke coming out, I will try to find a video after. But if that's too rare maybe we should just keep without using it.

@ghost
Copy link

ghost commented Aug 12, 2016

maybe it only shows up with low air temperature (condensation?)


Gesendet mit der Telekom Mail App
http://www.t-online.de/service/redir/email_app_android_sendmail_footer.htm

--- Original-Nachricht ---
Von: Gilberto Agostinho
Betreff: Re: [Harald67/c150] Smoke in the cabin (#13)
Datum: 12.08.2016, 15:01 Uhr
An: Harald67/c150
Cc: D-ECHO, Mention

@D-ECHO https://github.com/D-ECHO Ah, I see what you meant, sorry for
misunderstanding it!

I think in certain situations there is smoke coming out, I will try to find
a video after. But if that's too rare maybe we should just keep without
using it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13 (comment) , or
mute the thread
https://github.com/notifications/unsubscribe-auth/ALtQ-GlHOklAqUn8yVnVzwmQlId4gY-Jks5qfG62gaJpZM4JY3Me
.

@ghost
Copy link

ghost commented Aug 12, 2016

or did you maybe mixed it up with this one https://www.youtube.com/watch?v=G5IWNSaC6ME (0:40) ;)

@gilbertohasnofb
Copy link
Collaborator Author

@D-ECHO hehehe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants