Use substr method to determine file extension #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternatively use the "find_last_of" & "substr" methods on this conveniently and performance wise. This fixes the "." problem where we are working currently on a directory that contains ".", which prior to this will get rid of any occurences of this character from the original path (when using std::accumulate without a binary operation).
Alto1772
added a commit
to Alto1772/Kingship
that referenced
this pull request
Nov 13, 2023
briaguya-ai
approved these changes
Nov 14, 2023
Alto1772
added a commit
to Alto1772/Kingship
that referenced
this pull request
Nov 14, 2023
briaguya-ai
pushed a commit
to HarbourMasters/Shipwright
that referenced
this pull request
Nov 14, 2023
Archez
added a commit
to Archez/OTRExporter
that referenced
this pull request
Feb 27, 2024
Archez
added a commit
to Archez/OTRExporter
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively use the "find_last_of" & "substr" methods on this conveniently and performance wise.
This fixes the "." problem where we are working currently on a directory that contains ".", which prior to this will get rid of any occurences of this character from the original path (when using std::accumulate without a binary operation).
Will create PR at Shipwright once this one is accepted & merged...creates PR anyway