Fix PR artifacts workflow #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
force-pushed
the
pr-artifacts
branch
6 times, most recently
from
e7a7661
to
352553c
Compare
garrettjoecox
changed the title
garrettjoecox
changed the title
garrettjoecox
force-pushed
the
pr-artifacts
branch
from
352553c
to
7563d5d
Compare
|
I remember hearing the artifact builds would get removed after 5 days. Is this the same for nightly? |
garrettjoecox
force-pushed
the
pr-artifacts
branch
from
7563d5d
to
8585d84
Compare
The artifacts actually by default expire after 90 days, but I think there is a github UI bug or something that shows that they are all expired when viewing from a specific page |
Ah ok, I think 90 days is more than sufficient for now. |
garrettjoecox
force-pushed
the
pr-artifacts
branch
from
8585d84
to
23573ac
Compare
garrettjoecox
force-pushed
the
pr-artifacts
branch
from
23573ac
to
f649fc1
Compare
|
Working on local fork here: garrettjoecox#26 Won't work here until it's merged into develop (github actions requirement) |
dcvz
approved these changes
Nov 28, 2022
briaguya-ai
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the solution to determining the PR number here oprypin/nightly.link#37, specifically this old commit: https://github.com/oprypin/nightly.link/blob/4e83d1452dd1bf350ebe1a3910e395e6cf447fdf/.github/workflows/pr-comment.yml
This also updates the workflow to post nightly.link links, as the current links still require you to be authenticated with github