build soh with LUS 1.0.0 #2881
Merged
build soh with LUS 1.0.0 #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-changes soh/soh/Enhancements/game-interactor/GameInteractor_RawAction.cpp
Malkierian
reviewed
May 22, 2023
| extern "C" void DeinitOTR() { | ||
| SaveManager_ThreadPoolWait(); |
There was a problem hiding this comment.
I assume, having this moved to here instead of using the now removed ExitGame hook, means that DeinitOTR is being called when Alt+F4 or the title bar X are input?
There was a problem hiding this comment.
It should be, yes. This is called after the main game loop which is only hit when the window is closed.
inspectredc
reviewed
May 22, 2023
inspectredc
reviewed
May 22, 2023
Kenix3
changed the title
added 11 commits
June 2, 2023 23:23
leggettc18
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kinda lost with the current errors, maybe the CI will help me figure out what's broken?
Build Artifacts