Custom message improvements #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should result in much fewer allocations when rendering custom messages during a Randomizer playthrough.
This should allow for fewer allocations during randomizer seed generation and runtime, plus a couple of other enhancements that utilize custom messages. It does this by taking advantage of move semantics to prevent extraneous allocations when string literals are passed in. It also takes advantage of OOP to hopefully end up with a cleaner API.
briaguya-ai
reviewed
May 17, 2023
!
Archez
reviewed
May 17, 2023
|
Assuming I'm using Visual Studio's profiler correctly, after seed generation we seem to have dropped about 200 string allocations with this PR. |
briaguya-ai
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains what I think is a cleaner API for Custom Messages, and implements some move semantics so there should be fewer string allocations.
CustomMessageclass to replace theCustomMessageEntrys with something utilizing better object oriented design. This class should also properly utilize move semantics to prevent unnecessary string allocations when provided string literals orconst char*sReplaceStringInMessagemethods from theCustomMessageManagerand moves its functionality to the newCustomMessageclass'Replacefunctions.CustomMessage, such as capitalization.CustomMessageManagerwas used, replacing some unnecessarily heap allocated structs with stack-allocated ones (i.e. std::vector to std::array, or moving an array into the function where it was used.I would appreciate if someone could assist me in getting some sort of profiling going to verify that the claims about less allocation are true. I don't quite know how to check for that unfortunately.
Build Artifacts