Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Boss Rush #2923

Merged
merged 95 commits into from
Jun 2, 2023
Merged

[Feature] Boss Rush #2923

merged 95 commits into from
Jun 2, 2023

Conversation

aMannus
Copy link
Contributor

@aMannus aMannus commented May 26, 2023

Credits to @PurpleHato for providing the graphics for the Boss Rush logo and titles, the French translations for the options menu and helping me with some bits and bobs when I was losing my mind.

Credits to Timmy_GamerNepgear for the German translation for the options menu.

Build Artifacts

@aMannus aMannus marked this pull request as ready for review May 30, 2023 20:52
@aMannus
Copy link
Contributor Author

aMannus commented May 30, 2023

Fixed the UTF-8 problem now due to some help/guidance from @leggettc18 and @Archez , so I'm going to remove the draft status from the PR.

@Patrick12115
Copy link
Contributor

Only issues I came across in my first run was all Menu related. Going left after Boss Rush on the Quest Select screen crashes the game and I didn't have an MQ OTR to see if it would would with that there. And then the letting in the menu's didn't work well with the HD textures. Not just the new Boss Rush menu, but even just the filename menu, but only if going to the Boss Rush menu first. Toggling the HD textures while on the filename screen will kinda fix it, but seems like the ":" and "&" are still messed up afterwards.

2023-05-30-18-47-10_IijbjGcv.mp4

@aMannus
Copy link
Contributor Author

aMannus commented May 31, 2023

@Patrick12115 these should be fixed now. I have however introduced a kerning issue with special characters, but ran out of time for now.

Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall excited to see this finally out of draft phase. Quite a few cleanup/naming related comments, but nothing too major for now. Check out my comments when you have the chance, very close to the finish line here I believe!

soh/assets/soh_assets.h Show resolved Hide resolved
soh/include/z64save.h Outdated Show resolved Hide resolved
soh/soh/Enhancements/bossrush.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/bossrush.cpp Outdated Show resolved Hide resolved
soh/src/code/z_parameter.c Outdated Show resolved Hide resolved
soh/src/overlays/actors/ovl_Door_Warp1/z_door_warp1.c Outdated Show resolved Hide resolved
@leggettc18 leggettc18 merged commit 2957dc6 into HarbourMasters:develop Jun 2, 2023
@aMannus aMannus deleted the boss-rush branch June 7, 2023 11:51
@garrettjoecox garrettjoecox added this to the Sulu (7.1.x) milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants