Fix: Minimap dungeon entrance placement

[Archez]

This PR accomplishes a few goals around the minimap dungeon entrance icon:

• Fix the missing dungeon entrance icons due to authentic game data values and our custom Fast3D opcodes
• Fix dungeon entrance icon not positioning correctly with various hud placement settings
• Simply the dungeon entrance icon logic

The first issue I noticed when working on the Mirror World PR was that all the dungeon entrance icons (except for ice cavern) never appeared. Digging into it I found the issue is that the games data uses large negative values for the Y pos values here:

Shipwright/soh/src/code/z_map_data.c

Lines 227 to 229 in 7e1ee6e

	static s16 sOwEntranceIconPosY[24] = {
	0, -833, 0, 0, -850, -889, -829, 0, -844, 0, 0, -836, 0, 0, 0, -852, -873, 0, 0, -848, -825, -829, 0, -833,
	};

In hardware this is fine as the game uses gSPTextureRectangle which truncates the number and only keeps 12 bits (U10.2). The issue is after we introduced and switched to gSPWideTextureRectangle the value was now only truncated at 24 bits, meaning the icon would now be placed off screen. Early cosmetic editor days shows that we were applying an arbitrary + 1024 which pushed the authentic value back to a positive number in the range that it should have been, but after a later cosmetic editor change, this "fix" was running after all the checks and was effectively dead code.

To address this I am reapplying this fix at the beginning of all the logic to bitwise AND with 0x3FF to keep only the first 10 bits (and later will be shifted by 2 for the U10.2 value). I opted for the bitwise over the 1024 cause it felt more clear why it was happening.

The second issue I noticed is that all the cosmetic margin/anchor logic was essentially broken for the icon, so I've refactored it following the pattern used for the minimap itself.

Other refactorings I did was merge duplicate code paths under a single branch and apply the gAlwaysShowDungeonMinimapIcon in the right spot (where the entrance flag is checked).

The other fix I added was to display the correct minimap in randomizer:

• The Lake Hylia with filled lake minimap is now displayed when the water temple is cleared for rando
• The Gerudo Fortress map showing horse back archery is shown when the membership card is found for rando

Let me know if we want to reduce the scope of this PR

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[jbodner09]

Closes #2301 and #949

[briaguya-ai]

overall this looks great! thanks for fixing/cleaning this up!

left a few comments about places where adding a comment might help make the logic clearer, and one little question

[briaguya-ai]

one last little question, this looks pretty much good to go!

[briaguya-ai]

beautiful