[Fix] Reward Count Slider Defaults not registering #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to register changes.
Archez
approved these changes
Feb 1, 2024
|
I was already planning on streamlining the code for it, there's a LOT of redundancy that can be eliminated. I just didn't think it belonged in a fix PR like this. |
|
Ah ok if you're planning to address that in a follow up then that's fine 👍 |
briaguya-ai
approved these changes
Feb 2, 2024
garrettjoecox
approved these changes
Feb 2, 2024
garrettjoecox
merged commit e3825ec
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults for the reward count slider weren't registering when Greg As Reward was selected, as it was visually changing the value to the +1 that Greg would require without actually changing the CVar value, so it was still assumed to be the non-Greg default. This just unifies the default values for all the CVar slider options to make it clear that they need to actually be changed when Greg As Reward is selected with no previous CVar value.
Build Artifacts