Add virtual event support & filter enhancements #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hard-dance ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FlyersPh9
commented
Mar 3, 2024
| } | ||
| } | ||
|
|
||
| function filterPosts() { | ||
| const selectedLocation = locationSelect.value; | ||
| const selectedType = typeSelect.value; | ||
| const selectedHostClass = "filter-host-" + hostSelect.value; | ||
| let filterActive = false; // Flag to track if any filter is active |
There was a problem hiding this comment.
@rohan-kadkol I could use some help with this filters script.
- Filtering by Location > Virtual is not hooked up yet (and maybe it shouldn't be under location to begin with).
- The notification marker is not working as expected. You should see the red dot on the filter dropdown button if any filter is active.
- We should explore narrowing location down even further. Perhaps after a continent is selected you can then select a country?
- Can we save the filter options selected so if the user leaves the page and comes back we keep their preferences?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_onlinefront matter. While the Facebook API will be one or the other, I've added support for both at the same time.genreoption from front matter.