Fix Append Without Report Already Present #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Apr 29, 2022
### Description Appends test results to index.html instead of overwriting on retries using the [append option in the config](https://github.com/Hargne/jest-html-reporter#configuration). Update - 1: There were some issues with using the append option in [jest-html-reporter](https://github.com/Hargne/jest-html-reporter#readme); hopefully, Hargne/jest-html-reporter#145 is approved and we can update to the latest version to resolve these issues. Update - 2: The PR to jest-html-reporter was merged and the new version is used in this PR. ### Other changes N/A ### Tested Tested in CI. ### How others should test Does not need to be tested by QA. Reviewers should view the [e2e test reports](https://github.com/valora-inc/wallet/actions/runs/2234203686) and check that all tests are present. ### Related issues N/A ### Backwards compatibility Yes
ptabor
pushed a commit
to ptabor/jest-html-reporter
that referenced
this pull request
Sep 1, 2023
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the index.html was not already present appending was failing to create it. This pull request should fix that behavior.
Issues
When I attempt to run with my local version of the reporter I am getting the same issue seen in: #142
How others should test
Append Enabled - No Existing Report
report.htmlfile if present.Append Enabled - Existing Report
Append Disabled - No Existing Report
report.htmlfile if present.Append Disabled - Existing Report
Video - Example appended report
Screen.Recording.2022-04-26.at.12.17.56.PM.mov