-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to node-libcurl #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation throws this error:
I believe it can be fixed by this: https://stackoverflow.com/questions/63052127/protractor-node-libcurl-failed-ssl-peer-certificate-or-ssh-remote-key-was-not-o
The CA Certificates should normally be provided by the OS. What system is the bot running on? |
Hmm, I tested the PR on my own windows machine, but I'm not sure if the same problem would exist on Heroku. @Haroon96 maybe you can check? |
As it turns out, the error is common: https://github.com/JCMais/node-libcurl/blob/develop/COMMON_ISSUES.md |
Could you try now @osama-h-rana? |
@jhoogstraat working now on windows, sorry it took so long to review. Kinda busy during the week. |
This fixes the cloudflare issues which prevent the bot from accessing the tracker.gg api currently.
The system must have curl installed.