Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to node-libcurl #81

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Switch to node-libcurl #81

merged 2 commits into from
Feb 13, 2022

Conversation

jhoogstraat
Copy link
Contributor

@jhoogstraat jhoogstraat commented Feb 5, 2022

This fixes the cloudflare issues which prevent the bot from accessing the tracker.gg api currently.
The system must have curl installed.

Copy link
Collaborator

@osama-h-rana osama-h-rana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation throws this error:
image

I believe it can be fixed by this: https://stackoverflow.com/questions/63052127/protractor-node-libcurl-failed-ssl-peer-certificate-or-ssh-remote-key-was-not-o

@jhoogstraat
Copy link
Contributor Author

jhoogstraat commented Feb 6, 2022

The CA Certificates should normally be provided by the OS.
I can just include a copy of Mozilla's CA cert bundle, but thats rather uncommon. Moreover, it creates a new dependency to handle.

What system is the bot running on?

@osama-h-rana
Copy link
Collaborator

Hmm, I tested the PR on my own windows machine, but I'm not sure if the same problem would exist on Heroku. @Haroon96 maybe you can check?

This was referenced Feb 6, 2022
@jhoogstraat
Copy link
Contributor Author

As it turns out, the error is common: https://github.com/JCMais/node-libcurl/blob/develop/COMMON_ISSUES.md
I can add the third option.

@jhoogstraat
Copy link
Contributor Author

Could you try now @osama-h-rana?

@osama-h-rana
Copy link
Collaborator

@jhoogstraat working now on windows, sorry it took so long to review. Kinda busy during the week.

@Haroon96 Haroon96 merged commit 801f3ab into Haroon96:main Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants