Small kill feed bug fix (minimap.ts) #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some extra conditions to ensure that the key value reading is correct regardless of user's keyboard language. With the use of event.code.
Added some extra code to the getKeyFromInputEvent function so keyboard events are read correctly and regardless of user's keyboard language.
|
Ima look through that code and prolly approve it, needa talk to hasanger first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is intentional or not but while I was debugging some stuff, I noticed that the kill feed was not set to hidden when the "bigger" version of the map is opened by the player.
So yeh I just added two lines of code (
.show()and.hide()) to fix it lol