rename viewOffsetX to viewMarginX, plus many more #2714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename viewOffsetX/Y to viewMarginX/Y, also making all of these public, so you don't need to use the new getViewRect, to get the camera's view margin in world space, you can just use viewMarginLeft/Right/Top/Bottom. As well as various other helpers: viewX/Y/Width/Height to get the camera view in the world.
Important distinction:
view___
refers to the cameras view in world space. position a sprite atcamera.viewLeft
and it will be displayed on the left-most edge of the cameraviewMargin___
refers to the margin around the camera caused by zooming in/out. Camera's zoom into their center, cutting off a portion of the world so a simplecamera.scroll.x + camera.width
won't suffice to get the camera's right edge, butcamera.scroll.x + camera.viewMarginX + camera.viewWidth
will, as well ascamera.scroll.x + camera.viewMarginRight
(or simplycamera.viewRight
)