Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] signature completion with argument default values instead of just "?" #5538

Closed
Gama11 opened this issue Aug 24, 2016 · 5 comments
Closed
Assignees
Labels
feature-ide IDE / Editor support

Comments

@Gama11
Copy link
Member

Gama11 commented Aug 24, 2016

This is basically another instance of #2561 as a reminder:

According to @nadako, this info should be easy to provide in his new Json-based display output.

@Simn Simn modified the milestone: 4.0 Jan 9, 2017
@Gama11 Gama11 changed the title Signature completion with argument default values instead of just "?" [display] signature completion with argument default values instead of just "?" Mar 7, 2017
@Simn Simn modified the milestones: Release 4.0, Backlog Apr 17, 2018
@Simn Simn added the feature-ide IDE / Editor support label Apr 19, 2018
@Simn Simn self-assigned this May 11, 2018
@Simn
Copy link
Member

Simn commented May 11, 2018

This requires an appropriate structure to be defined in vshaxe first so I know what to target. Note that JsonFunctionSignature does not contain default values.

@Gama11
Copy link
Member Author

Gama11 commented May 30, 2018

Could we just add @:optional var value:String to JsonFunctionArgument to match what haxe.rtti.CType.FunctionArgument / dox has? Haxe doesn't have more info than that anyway, right?

@Simn
Copy link
Member

Simn commented May 30, 2018

It's a syntax expression, but we don't have a generate function for that yet.

@Gama11
Copy link
Member Author

Gama11 commented May 30, 2018

You mean for sending the default value as a proper expression structure rather than just a String? Hadn't really considered that, but that would probably be a good idea, especially if more complex default values such as enum values are allowed in the future..

@Gama11
Copy link
Member Author

Gama11 commented Jun 7, 2018

This is now fixed! \o/

@Gama11 Gama11 closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ide IDE / Editor support
Projects
None yet
Development

No branches or pull requests

2 participants