Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] improve workspace symbols performance #7056

Closed
Gama11 opened this issue May 21, 2018 · 1 comment
Closed

[display] improve workspace symbols performance #7056

Gama11 opened this issue May 21, 2018 · 1 comment

Comments

@Gama11
Copy link
Member

Gama11 commented May 21, 2018

One of the reasons why workspace symbols don't feel that responsive is probably the sheer amount of stuff it reports.. I don't think you really care about locals + function params at that level - it should be fine to only have them for document symbols. Especially if that means a performance boost.

I mean, seriously, "ignored" local vars too? :D

Another thing I've noticed in TypeScript's workspace symbols is that they only start returning results after you type at least a single character, while for Haxe is starts searching right away and usually hangs for a split-second because of that. That's probably something to implement on the vshaxe side though.

@Simn Simn closed this as completed in ac2c5f0 May 21, 2018
@kLabz
Copy link
Contributor

kLabz commented Jan 5, 2023

Another thing I've noticed in TypeScript's workspace symbols is that they only start returning results after you type at least a single character, while for Haxe is starts searching right away and usually hangs for a split-second because of that. That's probably something to implement on the vshaxe side though.

I'm not convinced by that part 🤔

I've disabled that behavior locally (removed ac2c5f0#diff-106d4296b9b6f4da4b6e1264b40faf39e98ce933e5512a6e4ec1d2467f36d229R620) to be able to do a filter-less workspace/symbol query on vim and throw the result at telescope to be able to fuzzy search on it, and it's pretty responsive:

Recording 2023-01-05 at 11 22 12
(request is sent when yellow cursor disappears, and total delay includes parsing the whole json)

Edit:
Admittedly, vscode is slower but that's partly because it seems to be debouncing there:
Recording 2023-01-05 at 11 29 57

But yeah, for typescript it does nothing until at least one character is typed. Not sure it's a good reason for us to prevent other tools from working with worspace-wide symbols, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants