Improvements to --help-defines and --help-metas #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gama11
reviewed
May 29, 2019
Gama11
reviewed
May 29, 2019
| @@ -44,7 +44,7 @@ let get_documentation d = | |||
| ) flags; | |||
| let params = (match List.rev !params with | |||
| | [] -> "" | |||
| | l -> "(" ^ String.concat "," l ^ ")" | |||
| | l -> "(<" ^ String.concat ">, <" l ^ ">) " | |||
There was a problem hiding this comment.
Why change the formatting of params?
There was a problem hiding this comment.
Thought it would be less ambiguous if each parameter is in <...>, since "params" contains multi-word descriptions.
|
Might wanna update the display protocol to include a |
Gama11
reviewed
May 29, 2019
Gama11
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--help-definesshows parameters