Support modules larger than 1 MiB #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial guard limited the codesize to 1 MiB, but the global function table would still work up to 15 MiB. ABI 2 Neko cannot read ABI 3, but ABI 3 Neko can still read ABI 2.
This was referenced Feb 14, 2014
|
See 33a9a46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an OpenFL project, I started getting a runtime launch error from Neko after adding some new dependencies (
Uncaught exception - std@module_read). I traced this down toneko_read_modulerejecting any modules with am->codesizelarger than0xFFFFF(1MiB).In addition, the current function table encoding doesn't leave enough space to refer to functions farther than
0xFFFFFFbytes (15 MiB) away.Of course these limits are probably here for a reason that I don't understand yet. Testing seems to confirm this with some large modules still not working, now just aborting silently with a misleadingly clean exit code of zero.
The modules that do work with the limits removed were very small originally; I just linked in some extra modules to increase their size (mainly: nape). I suspect that this works because the code above 1 MiB is never actually run.
For completeness, here is a patch to haxe and to the ocamllibs to output the modified bytecode for this patch.
tl;dr this patch is incomplete, what else need to change?