-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port from GTK 2 to GTK 3 #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyproto
force-pushed
the
gtk3
branch
2 times, most recently
from
December 22, 2020 13:19
30af816
to
d8b780f
Compare
The Azure pipeline error is unrelated to this pull request:
|
@tobil4sk Could you check if we want to merge this (after resolving conflicts)? It makes sense to not depend on EOL versions if it can be helped. |
tobil4sk
reviewed
Mar 27, 2023
tobil4sk
reviewed
Mar 27, 2023
Thanks for reviewing, and for maintaining Neko! |
andyli
pushed a commit
that referenced
this pull request
Jul 4, 2023
* Port from GTK 2 to GTK 3 * Update the Earthfile * Add missing line from README * Update the Earthfile # Conflicts: # CMakeLists.txt # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm maintaining the Neko package for Arch Linux.
GTK 2 has reached its end of life: https://blog.gtk.org/2020/12/16/gtk-4-0/
This patch changes the Neko sources from depending on GTK 2 to depending on GTK 3.
The only code change is calling
gdk_threads_add_timeout
instead of callinggtk_timeout_add
.The changes were tested with this simple Neko program, and appears to be working: