[WIP] Release v0.4.0 #134
Merged
[WIP] Release v0.4.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #132 |
Show tuner results in pandas dataframe
|
See the "Logging" section under the metal_commandments for an overview of the logging changes. |
ajratner
approved these changes
Feb 5, 2019
| @@ -3,6 +3,6 @@ multi_line_output=3 | |||
| include_trailing_comma=True | |||
| force_grid_wrap=0 | |||
| combine_as_imports=True | |||
| line_length=80 | |||
| line_length=88 | |||
There was a problem hiding this comment.
I'm seeing more libraries default to 88 instead of 80 (including our code formatter black, for which 88 is the default). It just makes the code a lot more readable; a whole lot of lines don't need to wrap now with just those extra 8 characters.
| - numpy | ||
| - pandas | ||
| - pytorch=0.4.1 | ||
| - pytorch=1.0 |
metal/classifier.py
Outdated
|
|
||
| def score( | ||
| # TEMPORARY FOR SLICING PROJECT; there may be a better way to do this |
There was a problem hiding this comment.
Should this be included on master? Probably not?
There was a problem hiding this comment.
Nope! Good catch. Removed.
This was referenced Feb 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers a series of issue fixes and upgrades. The largest breaking changes will be the upgrade to pytorch 1.0.0, restructuring to move all but the default input module (IdentityModule) into contrib/, and changing the structure of the logger/checkpointer/tensorboard config (more details to come on what that now looks like).