Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show podium with less than 4 members #95

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

HeadTriXz
Copy link
Owner

The podium should not be shown when there are not enough members to show it properly. It should only show it if there are more than 3 members.

@HeadTriXz HeadTriXz added bug Something isn't working barry labels Oct 27, 2023
@HeadTriXz HeadTriXz added this to the 1.0.0 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e4415e) 99.16% compared to head (c5ed148) 99.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         182      182           
  Lines       20374    20374           
  Branches     2248     2249    +1     
=======================================
  Hits        20203    20203           
  Misses        171      171           
Flag Coverage Δ
barry 98.95% <100.00%> (ø)
core 99.92% <ø> (ø)
logger 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ommands/chatinput/leaderboard/LeaderboardCanvas.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeadTriXz HeadTriXz merged commit ecf7b61 into main Oct 27, 2023
6 checks passed
@HeadTriXz HeadTriXz deleted the leaderboard-small branch October 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barry bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant