Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting text in modal can unexpectedly close it #998

Closed
joeskeen opened this issue Sep 24, 2019 · 1 comment · Fixed by #1011
Closed

Selecting text in modal can unexpectedly close it #998

joeskeen opened this issue Sep 24, 2019 · 1 comment · Fixed by #1011
Assignees
@andrew-frueh
Labels
bug new patch version number to the library released

Comments

@joeskeen
Copy link
Contributor

Summary

If there is text in an hc-modal that you as a user are selecting, and you drag your cursor over the edge of the modal, it registers it as a click on the backdrop and closes the modal. I've heard reports of multiple people being frustrated by this behavior.

Reproduction

https://stackblitz.com/edit/angular-g3beqz?file=src/app/modal-overview/modal-overview-example.component.ts

modal-selection
@andrew-frueh andrew-frueh self-assigned this Sep 25, 2019
@andrew-frueh andrew-frueh added behavior bug new patch version number to the library labels Sep 25, 2019
andrew-frueh added a commit to andrew-frueh/Fabric.Cashmere that referenced this issue Sep 28, 2019
@andrew-frueh
fix(modal): click drag outside modal
3139cb3 
prevents a click drag outside a modal from accidentally closing it

closes HealthCatalyst#998
@andrew-frueh andrew-frueh mentioned this issue Sep 28, 2019
Merged
@benjanderson
Copy link
Contributor

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-frueh andrew-frueh

Labels
bug new patch version number to the library released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): click drag outside modal andrew-frueh/Fabric.Cashmere
3 participants
@benjanderson @joeskeen @andrew-frueh